Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add npm run build to CI #481

Closed
nylen opened this issue Apr 21, 2017 · 0 comments
Closed

Add npm run build to CI #481

nylen opened this issue Apr 21, 2017 · 0 comments
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@nylen
Copy link
Member

nylen commented Apr 21, 2017

After #426 was merged and before #479 was merged, npm run build was broken with the following error:

ERROR in blocks/build/index.js from UglifyJs
Unexpected token punc «,», expected punc «:» [blocks/build/index.js:6733,55]

We should add this task to CI to prevent similar issues in the future.
@nylen nylen added Good First Issue An issue that's suitable for someone looking to contribute for the first time Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Task Issues or PRs that have been broken down into an individual action to take labels Apr 21, 2017
BE-Webdesign added a commit that referenced this issue Apr 24, 2017
@BE-Webdesign
Add build step to CI
22d38ea 
Fixes #481. Adds the build step to Travis CI.  Since we are using
webpack v2, the build will exit with a non zero error code, if any build
failures occur.
@BE-Webdesign BE-Webdesign mentioned this issue Apr 24, 2017
Merged
@yassine4999 yassine4999 mentioned this issue Nov 15, 2023
Open
@yassine4999 yassine4999 mentioned this issue Dec 27, 2023
Open
@yassine4999 yassine4999 mentioned this issue Jan 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nylen