-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flaky Test] should clear selection when clicking next to blocks #47279
Labels
[Type] Flaky Test
Auto-generated flaky test report issue
Comments
github-actions
bot
added
the
[Type] Flaky Test
Auto-generated flaky test report issue
label
Jan 19, 2023
This issue has gone 30 days without any activity. |
github-actions
bot
added
the
[Status] Stale
Gives the original author opportunity to update before closing. Can be reopened as needed.
label
Feb 20, 2023
github-actions
bot
removed
the
[Status] Stale
Gives the original author opportunity to update before closing. Can be reopened as needed.
label
Mar 31, 2023
This issue has gone 30 days without any activity. |
github-actions
bot
added
the
[Status] Stale
Gives the original author opportunity to update before closing. Can be reopened as needed.
label
Aug 25, 2023
github-actions
bot
removed
the
[Status] Stale
Gives the original author opportunity to update before closing. Can be reopened as needed.
label
Aug 31, 2023
This issue has gone 30 days without any activity. |
github-actions
bot
added
the
[Status] Stale
Gives the original author opportunity to update before closing. Can be reopened as needed.
label
Oct 9, 2023
github-actions
bot
removed
the
[Status] Stale
Gives the original author opportunity to update before closing. Can be reopened as needed.
label
Nov 2, 2023
github-actions bot
referenced
this issue
Nov 11, 2023
The Top Toolbar was relying on position: absolute; CSS and layoutEffect calculations to display the selected block tools visually within the top toolbar. This PR places it in the header DOM where we want it, allowing us to use native CSS and DOM flow to improve accessibility (tab order matches visual order) and have more maintainable code. * Imports `<BlockContextualToolbar />` via private-api and the <Popover /> for image captions to the edit site, edit post, edit widgets, and customize widget headers. * Removes position: absolute; and layoutEffect block toolbar positioning hacks. * CSS for the top toolbar to use flex-shrink and overflow-x: hidden; to allow for the block toolbar to fit its current space and scroll to reveal the hidden tools. * With top toolbar mode, Shift+Tab does not go directly to the toolbar but the first tabstop outside of the editor. Co-authored-by: Alex Lende <[email protected]> Co-authored-by: Andrei Draganescu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.
Test title
should clear selection when clicking next to blocks
Test path
/test/e2e/specs/editor/various/multi-block-selection.spec.js
Errors
[2023-01-19T10:27:21.706Z]
Test passed after 2 failed attempts onupdate/use-select-resubscribe
.[2023-01-20T11:43:47.679Z]
Test passed after 2 failed attempts onupdate/use-select-resubscribe
.[2023-03-30T10:48:12.983Z]
Test passed after 1 failed attempt ontry/footnotes-again
.[2023-04-05T16:02:03.995Z]
Test passed after 1 failed attempt ontry/block-tools-marry-document-tools
.[2023-06-22T17:29:14.316Z]
Test passed after 1 failed attempt ontry/perf-entity-prop
.[2023-07-21T12:58:18.788Z]
Test passed after 1 failed attempt onfeat/async-block-loading
.[2023-08-29T11:52:49.119Z]
Test passed after 1 failed attempt onupdate/make-shortcuts-provider-optional
.[2023-10-25T10:49:44.311Z]
Test passed after 1 failed attempt ontry/block-edit-lazy-loading
.[2023-11-11T00:16:41.440Z]
Test passed after 1 failed attempt ontrunk
.The text was updated successfully, but these errors were encountered: