Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global styles custom CSS help text wording #46669

Closed
dsas opened this issue Dec 20, 2022 · 2 comments · Fixed by #47091
Closed

Global styles custom CSS help text wording #46669

dsas opened this issue Dec 20, 2022 · 2 comments · Fixed by #47091
Assignees
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Copy Issues or PRs that need copy editing assistance

Comments

@dsas
Copy link
Contributor

dsas commented Dec 20, 2022

Description

I appreciate this is rather subjective, but I'm not sure that the wording to explain the Additional CSS input feels Gutenberg-y.

Is "Changes won't take effect until you've saved the template" necessary? The same thing goes for everything in Gutenberg, but it's not called out anywhere else.

If it is necessary then what does "the template" mean? If I've only added a style rule I haven't changed a template at all.

Something I have a weaker opinion on is whether "Enter your custom CSS in the textarea and preview in the editor." is necessary? It seems like a statement of the obvious but appreciate that might not be true for all.

Step-by-step reproduction instructions

  1. Go to Gutenberg Experiments page and toggle custom CSS experiment on
  2. Open up the site editor
  3. Open up global styles sidebar
  4. Press 'Custom' in the CSS section at the bottom

Screenshots, screen recording, code snippet

image

Environment info

Gutenberg 14.8

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@dsas dsas added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Dec 20, 2022
@skorasaurus skorasaurus added the [Type] Copy Issues or PRs that need copy editing assistance label Dec 27, 2022
@richtabor
Copy link
Member

richtabor commented Jan 11, 2023

Is "Changes won't take effect until you've saved the template" necessary?

The CSS actually impacts the whole site, not just a template; and that description text seems redundant. If anything, we could include the Learn more about CSS (https://wordpress.org/support/article/css/) link instead, which is employed in the Customizer currently.

CleanShot 2023-01-11 at 17 25 07@2x

@richtabor
Copy link
Member

richtabor commented Jan 11, 2023

Here's a mockup, using ExternalLink (same as the Image block's alt text):

CleanShot 2023-01-11 at 17 30 28@2x

Update:

I went ahead and pushed a quick PR for folks to try/see in real time.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 11, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants