Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote Block: Keyboard focus behavior differs from theme to theme #46546

Closed
t-hamano opened this issue Dec 14, 2022 · 5 comments
Closed

Quote Block: Keyboard focus behavior differs from theme to theme #46546

t-hamano opened this issue Dec 14, 2022 · 5 comments
Labels
[Block] Quote Affects the Quote Block [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@t-hamano
Copy link
Contributor

Description

When certain keystrokes are performed in a quote block, the behavior differs depending on the theme.

The quate block displays the block inserter button because the content consists of inner blocks. When the arrow-up key is pressed after the cite element has been given focus, its behavior varies depending on the theme.

Essentially, the first keystroke focuses on the block inserter and the second keystroke focuses on the innner block.

Screencast on Twenty Twenty Two
tt2_focus.mp4

Curiously, however, in Twenty Twenty Three, the focus is skipped on the block inserter and given to the inner block.

Screencast on Twenty Twenty Three
tt3_focus.mp4

I further investigated and found that this problem occurs when the cite element doesn't overlap the inserter.

Screencast on Twenty Twenty Three
tt3_focus.mp4

I don't know if this is a problem with the block editor or the writing flow, or just expected behavior of the browser, but I am reporting it as an issue.

Step-by-step reproduction instructions

  • Activate Twenty Twenty Three theme.
  • Insert a quote block.
  • Focus the cite element.
  • Press the arrow-up key.
  • Confirm that the block inserter disappears and the inner block comes into focus.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@priethor priethor added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [a11y] Keyboard & Focus labels Jul 24, 2023
@ellatrix ellatrix added the [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... label Aug 18, 2023
@ellatrix
Copy link
Member

This is probably fixed after #60307?

@t-hamano
Copy link
Contributor Author

#60307 seems to have removed the appender entirely, but when I select a block inside the Quote block, the quick inserter still appears in the top right. Is this intended?

Either way, I think this issue can be closed.

quote-block-inserter

@ellatrix
Copy link
Member

It's not just when selecting in list view, happens too without it. This is the empty default block inserter, it seems to be mispositioned. Let's rename this issue and fix it.

@ellatrix
Copy link
Member

Or let's open a new issue

@ellatrix
Copy link
Member

Done in #63517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Quote Affects the Quote Block [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

3 participants