Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Loading the fallback creates multiple wp_navigation CPTs #46194

Closed
scruffian opened this issue Nov 30, 2022 · 4 comments
Closed

Navigation: Loading the fallback creates multiple wp_navigation CPTs #46194

scruffian opened this issue Nov 30, 2022 · 4 comments
Labels
[Block] Navigation Affects the Navigation Block

Comments

@scruffian
Copy link
Contributor

What problem does this address?

When a navigation block is in a fallback state, it creates a draft wp_navigation CPT, once a user interacts with it. If this draft is not saved then, next time we load the block we load the fallback again, rather than the draft. This can lead to a situation where a user has multiple draft wp_navigation CPTs in their admin.

What is your proposed solution?

When the block is in a fallback state, we should delete draft wp_navigation CPTs, and create a new one with the latest fallback data, to avoid creating multiple useless drafts.

@scruffian scruffian added the [Block] Navigation Affects the Navigation Block label Nov 30, 2022
@getdave
Copy link
Contributor

getdave commented Mar 17, 2023

@scruffian Can we close this one out?

@scruffian
Copy link
Contributor Author

I don't think so no.

@getdave
Copy link
Contributor

getdave commented Mar 23, 2023

We have a few solutions in the works. We should be able to fix it if we can get one to land. For example #48698

@scruffian
Copy link
Contributor Author

This has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block
Projects
None yet
Development

No branches or pull requests

2 participants