Coupling of specific blocks to @wordpress/block-editor package

[getdave]

The Nav block offcanvas experiment is proceeding along. I'm noticing some instances where we're referencing specific block's within the @wordpress/block-editor package.

I'd like to document these below for refactoring later. We should be thinking about

• Trying to make the behaviour generic
• Moving the code to the block itself (use slots/filters...)
• Making use of block editor settings

Instances

• Page List Item: hide edit button #46163 line
• Display inserter popover in offcanvas UI #46013
  • line
  • line
• Check for core/page-list line
• Check for core/navigation-submenu line

[georgeh]

In #45984 we are hard-coding core/page-list for the convert-to-links modal

gutenberg/packages/block-editor/src/components/off-canvas-editor/block-edit-button.js

Lines 178 to 179 in d970deb

	const allowConvertToLinks =
	'core/page-list' === block.name && totalPages <= MAX_PAGE_COUNT;