FontSizePicker: new t-shirt sizes don't match the existing font sizes in some themes #45268
Labels
[Feature] Typography
Font and typography-related issues and PRs
[Package] Components
/packages/components
[Status] Duplicate
Used to indicate that a current issue matches an existing one and can be closed
Description
In #43074, the font size ToggleGroupControl now displays the t-shirt size as the button name. I'm concerned that this may cause confusion in many themes that define font size variations.
For example, in the following theme, the button text and tooltips seem to be at odds with each other:
Twenty Twenty or Twenty Twenty Two
That is, if you are already using your own t-shirt size or if the beginning is not an S (e.g., XS).
I understand that this is a change to improve design consistency, but I believe it will have a significant impact on existing consumers. Therefore, I would like to propose the following changes:
Option to force selectbox
If there are more than 6 font size variations, the select box will be displayed and the t-shirt size will not be displayed. Therefore, I believe it would be useful to have an option to force a select box without having to add the necessary variations to make it a select box.
Option to change button text
In addition to
size
,slug
, andname
, add properties to change the button text. For example,shortName
.shortName
seems to be customarily used in the Classic theme, as seen in these issues (I'm not sure when this property appeared, and it doesn't appear to be considered in the latest WordPress/Gutenberg.@ramonjd, @jasmussen
If there is anything I am missing or misunderstanding, please let me know 🙏
Step-by-step reproduction instructions
Activate Twenty Twenty or Twenty Twenty Two and check the font size picker text and tooltip labels.
The text was updated successfully, but these errors were encountered: