Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose a block menu showing over the modal #44767

Closed
imanish003 opened this issue Oct 7, 2022 · 1 comment · Fixed by #44795
Closed

Choose a block menu showing over the modal #44767

imanish003 opened this issue Oct 7, 2022 · 1 comment · Fixed by #44795
Assignees
Labels
[Block] Pattern Affects the Patterns Block [Type] Bug An existing feature does not function as intended

Comments

@imanish003
Copy link
Contributor

Description

As you can see in the screenshot below, choose block menu appears over the Patterns modal.
image

Expected behavior

The choose a block menu should be behind the modal, in this case, the patterns modal.

Step-by-step reproduction instructions

  1. Edit any post & type /woo, and the following menu will appear:
    image

  2. Click on the plus button available in the top left corner
    image

  3. Go to the patterns tab and click on Explore button while choose a block menu is still open.
    image
    and you will see the issue
    image

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Pattern Affects the Patterns Block labels Oct 8, 2022
@BE-Webdesign
Copy link
Contributor

Can replicate, unfortunately this probably can't be fixed with just some CSS as it seems on purpose that components-popover has a higher z-index than components-modal__screen-overlay. I will make a PR that fixes this with a click outside for the popover.

// Show modal under the wp-admin menus and the popover
".components-modal__screen-overlay": 100000,

// Show popovers above wp-admin menus and submenus and sidebar:
// #adminmenuwrap { z-index: 9990 }
".components-popover": 1000000,

@BE-Webdesign BE-Webdesign self-assigned this Oct 8, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 9, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Pattern Affects the Patterns Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants