Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current menu item doesn't work with custom homepages #43843

Closed
draganescu opened this issue Sep 5, 2022 · 1 comment · Fixed by #43800
Closed

Current menu item doesn't work with custom homepages #43843

draganescu opened this issue Sep 5, 2022 · 1 comment · Fixed by #43800
Labels
[Block] Navigation Affects the Navigation Block Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended

Comments

@draganescu
Copy link
Contributor

The Navigation block's current menu item class doesn't seem to work for the blog when the home page is set to a static page. i.e. If the blog itself is actually a page, the navigation menu doesn't get the current-menu-item class added to it.

Originally posted by @timnicholson in #19993 (comment)
@draganescu draganescu added [Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended Needs Testing Needs further testing to be confirmed. labels Sep 5, 2022
@carolinan
Copy link
Contributor

This is solved in #43800

@draganescu draganescu mentioned this issue Sep 5, 2022
Merged
@draganescu draganescu added the [Status] In Progress Tracking issues with work in progress label Sep 5, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Navigation Affects the Navigation Block Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Navigation: add current-menu-item also for archive links WordPress/gutenberg
3 participants
@draganescu @carolinan @priethor