Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon: Deprecate dashicon strings #43725

Open
mirka opened this issue Aug 30, 2022 · 2 comments
Open

Icon: Deprecate dashicon strings #43725

mirka opened this issue Aug 30, 2022 · 2 comments
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Comments

@mirka
Copy link
Member

mirka commented Aug 30, 2022

It was suggested in #27461 (comment) that dashicons strings be deprecated from the Icon component, in favor of SVGs.

Note that this will also affect components that rely on Icon and accept arbitrary icon values, such as Button and DropdownMenu.

@mirka
Copy link
Member Author

mirka commented Aug 31, 2022

It has come to my attention that the Icon component is responsible for rendering block icons, where I would imagine dashicons to be widely used.

So this itself could be considered a blocker to deprecating.

@t-hamano
Copy link
Contributor

Mentions #44205 as it may be relevant to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants