Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving intuition of the 'Query' pattern category #43427

Closed
jameskoster opened this issue Aug 19, 2022 · 8 comments
Closed

Improving intuition of the 'Query' pattern category #43427

jameskoster opened this issue Aug 19, 2022 · 8 comments
Labels
[Block] Query Loop Affects the Query Loop Block [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Priority] High Used to indicate top priority items that need quick attention [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Aug 19, 2022

Screenshot 2022-08-19 at 13 52 17

One of these is not like the others. Unless you're familiar with the inner workings of WordPress, 'Query' is probably going to sound a bit alien.

Ideally Query variations should be dynamically built based on existing post types (#40941). Then we can use similar logic to populate the category list in the Patterns tab. For example when a product post type exists I should find a 'Products' pattern category, and a 'Products List' Query variation.

But until such logic has been installed, we might consider renaming this category to 'Posts'.

@jameskoster jameskoster added [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Block] Query Loop Affects the Query Loop Block labels Aug 19, 2022
@mtias
Copy link
Member

mtias commented Aug 19, 2022

100%, it's really unfortunate we still have this category exposed to users. Maybe Blog Posts for clarity or are we fine with just Posts?

@jameskoster
Copy link
Contributor Author

Yes I would be in favor of that. Appending/Prepending instances of "posts" with "Blog" is likely to be a requirement in other areas of the site editing UI to contextualise between generic 'posts', and the post post type.

@priethor priethor added the [Priority] High Used to indicate top priority items that need quick attention label Aug 19, 2022
@antonyjsmith
Copy link

But it's describing it for what it is, a query and the term can encompass multiple post types already without the need for additional logic. Feels like complexity for the sake of it rather than trying to educating a user.

Plus you need a pretty good grasp of Wordpress to get the best out of Gutenberg anyway and this'll be another one of those annoying changes that then change again.

@jameskoster
Copy link
Contributor Author

Yes but patterns are generally designed with a certain post type in mind. If a user wants to insert a Products grid, it's not helpful that they have to sift through patterns designed for projects, recipes, blog posts, and so on.

So there's two approaches – have subcategories beneath 'Query', or just elevate those 'sub' categories to the top level and hide the generic 'Query'. I don't have a strong opinion either way, the most important thing imo is to present categories that resonate more with less technical users.

@antonyjsmith
Copy link

Are they? In my experience patterns are generally agnostic. Plus only one pattern category in that drop down is for a specific post type and that's pages e.g buttons, gallery, columns etc can be used anywhere and not for a specific post type, under the assumption 'everything a block' so all patterns should work anywhere.

Finally, returning to the original rational, post type is a Wordpress concept, so to understand post type is to understand the workings of Wordpress.

@annezazu
Copy link
Contributor

Removing from 6.1 editor tasks as we've entered feature freeze.

@annezazu
Copy link
Contributor

Curious if this can be closed or what remains after this recent PR merge that included renaming Query to Posts: #45244 (review)

@jameskoster
Copy link
Contributor Author

Certainly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Priority] High Used to indicate top priority items that need quick attention [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Development

No branches or pull requests

5 participants