Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useRootPaddingAwareAlignments prevents color changes in Global Styles from displaying in the Site Editor #43033

Closed
ndiego opened this issue Aug 5, 2022 · 2 comments
Closed

useRootPaddingAwareAlignments prevents color changes in Global Styles from displaying in the Site Editor #43033

ndiego opened this issue Aug 5, 2022 · 2 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Comments

@ndiego
Copy link
Member

ndiego commented Aug 5, 2022

Description

When you enable the new "useRootPaddingAwareAlignments": true feature, changing colors in the Site Editor are no longer actually reflected in the Site Editor. They do appear on the frontend.

Step-by-step reproduction instructions

  1. Use Twenty Twenty-Two and Gutenberg 13.8+
  2. Set "useRootPaddingAwareAlignments": true in theme.json
  3. Change the background color of the site in Global Styles to another color. See that the color does not change in the Site Editor.
  4. Save your changes and see that the color has been changed on the frontend.

Screenshots, screen recording, code snippet

No response

Environment info

  • WordPress 6.0.x
  • Gutenberg 13.8.1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@ndiego ndiego added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended labels Aug 5, 2022
@ndiego ndiego mentioned this issue Aug 5, 2022
Closed
@ndiego ndiego changed the title useRootPaddingAwareAlignments prevents color changes in Global Styles to appear in the Site Editor useRootPaddingAwareAlignments prevents color changes in Global Styles from displaying in the Site Editor Aug 5, 2022
@Gierand
Copy link

Gierand commented Aug 5, 2022

@ndiego Please check #42913

@ndiego
Copy link
Member Author

ndiego commented Aug 5, 2022

Ahh, thanks @Gierand. Completely missed that!

@ndiego ndiego closed this as completed Aug 5, 2022
@MaggieCabrera MaggieCabrera mentioned this issue Aug 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gierand @ndiego