Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputControl: Fix LabelWrapper line-height inconsistency #42788

Open
mirka opened this issue Jul 28, 2022 · 0 comments
Open

InputControl: Fix LabelWrapper line-height inconsistency #42788

mirka opened this issue Jul 28, 2022 · 0 comments
Assignees
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Comments

@mirka
Copy link
Member

mirka commented Jul 28, 2022

Due to an extra wrapper, the labels on InputControl-based components render with a slightly different height than those based on BaseControl. This is currently necessitating a hack in ToolsPanel, where the such components are frequently rendered side by side:

/**
* Standardize InputControl and BaseControl labels with other labels when
* inside ToolsPanel.
*
* This is a temporary fix until the different control components have their
* labels normalized.
*/
&& ${ LabelWrapper } {
label {
line-height: 1.4em;
}
}

@mirka mirka added the [Package] Components /packages/components label Jul 28, 2022
@mirka mirka self-assigned this Jul 28, 2022
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants