Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Width support is missing from theme.json #42159

Open
roseg43 opened this issue Jul 5, 2022 · 0 comments
Open

Search: Width support is missing from theme.json #42159

roseg43 opened this issue Jul 5, 2022 · 0 comments
Labels
[Block] Search Affects the Search Block - used to display a search field [Type] Enhancement A suggestion for improvement.

Comments

@roseg43
Copy link
Contributor

roseg43 commented Jul 5, 2022

What problem does this address?

This issue is meant to be a follow-up feature for #42079, suggested by @skorasaurus . After adding support to toggle the Width settings panel for the Button block using theme.json, we should add the same support for the Width setting on the Search block now that there will be a related property intheme.json.

What is your proposed solution?

In the Search block's Edit component, only show the Width setting if true === spacing.width in theme.json, using useSetting() to get the value of spacing.width

@skorasaurus skorasaurus added [Block] Search Affects the Search Block - used to display a search field [Type] Enhancement A suggestion for improvement. labels Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Search Affects the Search Block - used to display a search field [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants