-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post comment form block styles are overriding button elements theme.json styles #42052
Comments
I don't think the styles from core/button should be applied to this block as it's not a button block. You should try setting the styles using |
I think it makes sense to render the submit button as a core/button block. But if that's not the case, I'm curious about why the submit button has the
I'm not sure if this is what you suggest, but, using these settings in
|
I believe this was so that it would inherit the rules of the buttons block, but it's a fragile way of doing things. Now we have button elements we should be using that mechanism to control the appearance of all buttons, like so:
|
Thanks for the context. Using your latest snippet, the styles are still overridden by the core/post-comments-form styles. |
Yeah that makes sense, but now at least we're on the same page about how it should work! |
Description
It seems like post comment form block styles are overriding button elements theme.json.
Step-by-step reproduction instructions
theme.json
settings for core/button block:Screenshots, screen recording, code snippet
Environment info
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: