Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Part: Swap 'Edit' and 'Replace' action placement #41437

Closed
jameskoster opened this issue May 30, 2022 · 3 comments · Fixed by #42221
Closed

Template Part: Swap 'Edit' and 'Replace' action placement #41437

jameskoster opened this issue May 30, 2022 · 3 comments · Fixed by #42221
Assignees
Labels
[Block] Template Part Affects the Template Parts Block

Comments

@jameskoster
Copy link
Contributor

jameskoster commented May 30, 2022

Currently 'Replace' is a primary action, present in the template part block toolbar, while 'Edit' is hidden away in the ellipsis menu:

Screenshot 2022-05-30 at 15 33 53

In most cases it's more likely that you'd want to edit the selected template part, so that should be the primary action. Replacing should be secondary.

Suggested revision:

Screenshot 2022-05-30 at 16 38 07

There may even be an argument that having the Edit button in the toolbar is too prominent since you can already directly manipulate the template part contents. But since the toolbar has very few actions, I think it might be ok to try, especially as focus mode may be the preferred editing mode for some users.

@jameskoster jameskoster added the [Block] Template Part Affects the Template Parts Block label May 30, 2022
@carolinan
Copy link
Contributor

carolinan commented Jun 10, 2022

The EditTemplatePartMenuButton is a component under edit site, I do not know what the best practice is for making it available in the top level of the block toolbar?
If it is not going to be used in the block settings menu anymore, do we re-create it, but in a utility file for the specific block?

@Mamaduka Mamaduka self-assigned this Jun 30, 2022
@Mamaduka
Copy link
Member

Mamaduka commented Jul 6, 2022

@jameskoster started working on this issue; I'll have PR ready for testing before the end of the week.

Question: I don't think we have Slot in the "Remove block" menu group. Is it okay to add "Replace" where we currently have the "Edit" menu item?

Screenshot

CleanShot 2022-07-06 at 15 02 36

@jameskoster
Copy link
Contributor Author

@Mamaduka yes I think that's fine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants