Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Clicking "Browse all footers" shows list of all template parts (not just footers). #41170

Closed
johnstonphilip opened this issue May 19, 2022 · 2 comments · Fixed by #42350
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@johnstonphilip
Copy link
Contributor

Description

When I have only a single footer template part in my theme, in the site editor I can click "Browse all Footers", which then takes me to see all of the template parts in my theme, even my header (which is not a footer).

The issue here seems to be that the terminology is wrong. It should say "Browse all Template Parts".

Step-by-step reproduction instructions

  1. Install the Frost FSE theme: https://github.com/wpengine/frost
  2. Go to "Appearance" > "Site Editor".
  3. Click on "Template Parts" in the sidebar.
  4. Click to edit the "footer".
  5. At the top click the toggle-down beside the template part title, and then click on "Browse all Footers".
  6. Notice you are now taken to see all of your site's template parts, not just "footers".

Screenshots, screen recording, code snippet

Screen Shot 2022-05-19 at 3 59 11 PM

Environment info

  • WP Version: 6.0-RC3-53412
  • Gutenberg disabled.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels May 20, 2022
@Mamaduka
Copy link
Member

Mamaduka commented Jul 7, 2022

@johnstonphilip, it looks like filtering hasn't been implemented yet.

const browseAllLinkProps = useLink( {
// TODO: We should update this to filter by template part's areas as well.
postType: template.type,
postId: undefined,
} );

@jameskoster, should we update the label as suggested in the issue?

@jameskoster
Copy link
Contributor

Good catch. Yes I think we should probably update the label until we implement #36613, or some filtering on the template part list like you mentioned.

@Mamaduka Mamaduka self-assigned this Jul 7, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 12, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants