Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Scroll to the Bottom of Long Posts #41116

Closed
mchowning opened this issue May 17, 2022 · 3 comments
Closed

Unable to Scroll to the Bottom of Long Posts #41116

mchowning opened this issue May 17, 2022 · 3 comments
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] High Used to indicate top priority items that need quick attention

Comments

@mchowning
Copy link
Contributor

mchowning commented May 17, 2022

Description

When scrolling to the bottom of a very long post, the block list gets "reset" and returns me to the beginning of the post. This essentially makes it impossible to scroll to the end of a long post.

It feels like both Android and iOS should have this issue, but I have only been able to reproduce this issue on Android.

I've found it easier to reproduce this issue on slower builds (i.e., the demo app or a debuggable WordPress app build). The faster the build, the longer the post I seem to need to recreate the issue.

Step-by-step reproduction instructions

  1. Open a long post (500 paragraphs should be more than enough)
  2. Quickly scroll to the bottom of the post (if the bug doesn't occur scroll back to the middle of the post and then back to the bottom again until the bug occurs)
  3. Observe that the scrolling will stop and you will suddenly be back at the top of the post.

Expected behaviour

Scrolling through the post should be fluid and not return you to the top of the post

Actual behaviour

On long posts, you are sometimes returned to the start of the post.

Screenshots or screen recording

scroll_to_top_bug.mp4
This screen recording is with the WPAndroid 19.9-rc-1 release build.

Device information

  • Device: Pixel 3 and Pixel 6 Pro
  • Operating system: Android 12
  • WordPress app version: 19.9-rc-1 (I have not been able to recreate this issue on 19.8)
@mchowning mchowning added [Priority] High Used to indicate top priority items that need quick attention Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels May 17, 2022
@mchowning
Copy link
Contributor Author

mchowning commented May 17, 2022

I can "fix" this issue by commenting out the CellRendererComponent prop within our BlockList, but of course that breaks the new drag and drop functionality. It's not clear to me why commenting that out is fixing the issue, but hopefully it can help point us in the right direction for a proper fix.

#39089 is the PR that added the CellRendererComponent, cc: @geriux and @fluiddot

@fluiddot
Copy link
Contributor

I can "fix" this issue by commenting out the CellRendererComponent prop within our BlockList, but of course that breaks the new drag and drop functionality. It's not clear to me why commenting that out is fixing the issue, but hopefully it can help point us in the right direction for a proper fix.

#39089 is the PR that added the CellRendererComponent, cc: @geriux and @fluiddot

@mchowning, good catch! @geriux already addressed the issue with the CellRendererComponent in this PR 🎊 . Looks like this issue and wordpress-mobile/gutenberg-mobile#4864 are both related to the onLayout handler on that component, so that fix will most likely solve both at the same time.

@geriux
Copy link
Member

geriux commented May 18, 2022

I can confirm that #41105 fixes the issue so I'll close this since it was already merged 👍

@geriux geriux closed this as completed May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] High Used to indicate top priority items that need quick attention
Projects
None yet
Development

No branches or pull requests

3 participants