Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Styles: default style picker gone(?) #41017

Closed
florianbrinkmann opened this issue May 12, 2022 · 5 comments
Closed

Block Styles: default style picker gone(?) #41017

florianbrinkmann opened this issue May 12, 2022 · 5 comments
Labels
[Type] Regression Related to a regression in the latest release

Comments

@florianbrinkmann
Copy link

Description

I went through the options of the block.json and noticed the one that allows to hide the block style default picker. I was not sure where that picker was displayed, so I opened the editor, selected a block with a block style (quote block) and was not able to find the select option. I searched if that was removed somewhere, but only found a PR from November where it was still there (#36976)

Step-by-step reproduction instructions

  1. Go to the block editor
  2. Select a block with styles (quote, for example)
  3. Search for the default style select in the block sidebar

Screenshots, screen recording, code snippet

grafik

Environment info

  • WordPress 6 RC 2, no Gutenberg plugin enabled.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@aristath
Copy link
Member

aristath commented May 12, 2022

I just noticed the same thing a few minutes ago and was wondering what happened...
I can confirm that the default block-style selector is no longer there (using Gutenberg trunk)

@aristath aristath added the [Type] Regression Related to a regression in the latest release label May 12, 2022
@Mamaduka
Copy link
Member

cc @ramonjd

@ramonjd
Copy link
Member

ramonjd commented May 12, 2022

Thanks for the ping!

Removing the default style picker was a deliberate measure. See this comment from @mtias :

Let's skip the "make default" for now as we need to reintroduce it better with global styles anyways. The current behaviour is in itself odd since it doesn't change existing styles but modifies what gets inserted as a default going forwards. It predates global styles which is a better layer of abstraction there. We'll need mechanisms for making any set of customization to block supports work globally from the local context, so when we get into that we can develop a more comprehensive design. For now let's try removing that functionality.

Source: #34522 (comment)
Related design comment: #34522 (comment)

The intention was to hook block style defaults into global styles, though I can't find any progress on that. Would it be something folks are interested in pursuing?

Of course reinstating the dropdown is another course of action if people miss the functionality, and think it's worth adding back in.

Cheers!

@florianbrinkmann
Copy link
Author

Thanks for the info! Just wanted to make sure it is not a regression :)

@mtias
Copy link
Member

mtias commented May 21, 2022

Yes, it's something we need to revisit but as part of global styles (the per block section). The default style felt too much like a hack and was confusing people. In the future we should be able to jump from local styles into global styles, and promote any local styles as "I want these to be the styles applied to all blocks of this type". A lot of things to pursue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

5 participants