Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child Navigation default background with Dark Header #40908

Closed
courtneyr-dev opened this issue May 7, 2022 · 5 comments
Closed

Child Navigation default background with Dark Header #40908

courtneyr-dev opened this issue May 7, 2022 · 5 comments
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.

Comments

@courtneyr-dev
Copy link
Contributor

WordPress 6.0 RC1, Twenty Twenty Two, Theme Unit Test Data installed.

image

What problem does this address?

Default installs with Twenty Twenty Two active + child navigation item have a default background of white font on white background. The default header is a dark background. I can't see the child navigation text without first adjusting the navigation block background color.

What is your proposed solution?

All navigation block backgrounds should Inherit the same background color as the default header. This should not be transparent.

@bph
Copy link
Contributor

bph commented May 7, 2022

Great find @courtneyr-dev
I am not sure if that's a Gutenberg issue, though. It looks to me that this needs to be fixed via Twenty-Twenty-Two theme, I filed a trac ticket as well.
.. pinging @jffng

@bph bph added [Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked. labels May 7, 2022
@bph bph assigned jffng and unassigned jffng May 7, 2022
@getsource
Copy link
Member

getsource commented May 17, 2022

Folks chatted about this issue in a Core triage session today.

Leaving a note here because follow-up testing on the Core ticket (comment from @carolinan) mentions that the issue is with link color specificity in the Editor.

The Core ticket is still open because a workaround is being discussed.

@carolinan
Copy link
Contributor

Can confirm that this is still an issue in current Gutenberg trunk (14.0.3+).

@jasmussen
Copy link
Contributor

This should be fixed by #44578.

Repository owner moved this from Triage to Done in WordPress 6.0.x Editor Tasks Oct 3, 2022
@bph
Copy link
Contributor

bph commented Oct 6, 2022

Tested it again this morning and yes, it has been fixed.
Using WordPress 6.1 Beta 3 alone didn't fix it. It only is resolved after installing Gutenberg Nightly (includes 14.3 RC).

Before

Before-14.3.mp4

After

After-14.3.mp4

Also closed trac issue as reported upstream

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.
Projects
No open projects
7 participants