Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google maps as an embed #3970

Closed
karmatosed opened this issue Dec 13, 2017 · 5 comments
Closed

Add google maps as an embed #3970

karmatosed opened this issue Dec 13, 2017 · 5 comments
Assignees
Labels
[Feature] Blocks Overall functionality of blocks New Block Suggestion for a new block

Comments

@karmatosed
Copy link
Member

karmatosed commented Dec 13, 2017

This is a user request from the forums: https://wordpress.org/support/topic/great-new-tool/#post-9765086

@karmatosed karmatosed changed the title Consider adding google maps embed Add google maps as an embed Dec 13, 2017
@Soean Soean added [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement. labels Dec 13, 2017
@overclokk
Copy link

Maybe this is better in plugins and not in core bacause gmaps has a lot of customizations.

@aduth
Copy link
Member

aduth commented Dec 14, 2017

Related: #315

@Soean Soean added New Block Suggestion for a new block and removed [Type] Enhancement A suggestion for improvement. labels Dec 14, 2017
@ellatrix
Copy link
Member

We can do this without API keys or oEmbed. #4660 semi addresses this, but in addition to that we could create a proper embed block for Google maps where the user can paste the iframe embed code and the block just saves the iframe attributes and URL. A content filter could put this into an iframe similar to the way oEmbed works, so in other words, the Google Maps domain would be whitelisted to use iframes.

@ellatrix ellatrix self-assigned this Jan 25, 2018
@ellatrix
Copy link
Member

Anything other than the iframe embed code would be plugin material though.

@mtias
Copy link
Member

mtias commented Mar 6, 2018

Duplicate of #315.

@mtias mtias closed this as completed Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks New Block Suggestion for a new block
Projects
None yet
Development

No branches or pull requests

6 participants