-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flex layout: Wrap multiple lines as default #39651
Comments
I think this means that we should also add a "column" variation to the "group" block. Changing the orientation of a row block should be the same as "transforming it to a column variation" |
row-wrap.mp4Which matches with the code. I wonder why it is showing off by default for you? |
This was straight from @mtias's report. I've tested this and can confirm it's turned on by default both in the post and site editor, with the Skatepark theme being used. |
Interesting, not sure what happened there. |
Tested this again because it didn't make sense to me. The problem is "wrap to multiple lines" is on by default not off by default on the row block: When turned on, it is allowing wrapping of child blocks in the row. That's nothing to do with a paragraph child block wrapping text to multiple lines because of restricted space. So -- this setting turned off by default actually provides the outcome you would expect with a row block, where child blocks stay on a single line. |
Ah, good catch, that's what I had in mind — the behaviour where things fit on a single line by default, which is what you'd expect most often when choosing a Row. Otherwise if you have any line of text that is slightly long it'd seem like it's not working properly. Thanks for looking back :D |
If we do change the behavior here. Let's make sure we don't regress on other blocks using "flex" where the "off" by default might not be the right call. (Navigation, buttons, social links, maybe others) |
Description
With the row block and using orientation and justification in layout settings the "Allow to wrap to multiple lines" setting is set as off by default. This means the typical user experience will go like this:
Screeny.Video.22.Mar.2022.at.18.47.33.mov
By setting the wrap setting to on by default you'd automatically get something like this, which is I think what most users would expect:
Let's default this setting to on.
The text was updated successfully, but these errors were encountered: