Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Part: Make it clearer which is currently in use in replace modal #39298

Open
annezazu opened this issue Mar 9, 2022 · 4 comments
Open
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented Mar 9, 2022

What problem does this address?

This came up as part of the FSE Outreach Program's twelfth call for testing:

(In modul) Current in use template part should always show in the top left corner with the words in use/current (perhaps also an extra border around it or some other visual mark to say current in use). Making it obvious which header/template part is currently in use.

current.headeer.mov

What is your proposed solution?

Have a way to indicate the current in use template part. The same likely needs to happen when switching between pattern options as well as it may not be clear at a glance what is currently in use.

cc @jameskoster since I know you're exploring things here!

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. Needs Design Needs design efforts. [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Block] Template Part Affects the Template Parts Block labels Mar 9, 2022
@jameskoster
Copy link
Contributor

We often use blue outlines to indicate selection throughout the UI. This convention could probably work here as well:

Screenshot 2022-03-09 at 10 30 22

What do you think?

@annezazu
Copy link
Contributor Author

annezazu commented Mar 9, 2022

Ship it. I dig (as long as this will also be clear from an accessibility standpoint too).

@jameskoster jameskoster added Needs Dev Ready for, and needs developer efforts and removed Needs Design Needs design efforts. labels Mar 10, 2022
@paaljoachim
Copy link
Contributor

That sounds helpful!

@ribaricplusplus
Copy link
Member

ribaricplusplus commented Apr 2, 2022

I'm not sure if it makes sense to implement this for patterns. What happens when a user selects a pattern and then changes it? By change, I mean change the properties of the blocks in the pattern, for example. It would be confusing to still show the pattern as "selected" in the modal, wouldn't it?

Also, the current behavior is to remove the template part which is in use from the modal. So I'm not sure that the issue demonstrated in the video, which shows patterns, and the proposed design, which shows template parts, are on the same page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants