Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visual cue when dragging a block into an empty Group block #39064

Closed
richtabor opened this issue Feb 24, 2022 · 9 comments · Fixed by #50826
Closed

Add visual cue when dragging a block into an empty Group block #39064

richtabor opened this issue Feb 24, 2022 · 9 comments · Fixed by #50826
Assignees
Labels
[Block] Group Affects the Group Block [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

richtabor commented Feb 24, 2022

While we actually can drag and drop another block into an empty Group block, there's no visual to indicate that its possible.

Proposal

Add a design visual when dragging another block over an empty group (or columns) block. We can use the same DropZone styling and animations to "fill" the empty inserter and add the + icon.

Visuals

Proposal

CleanShot.2023-05-05.at.15.25.50.mp4

Current

For reference, here is what we have today (no visual indicator):

CleanShot.2022-02-24.at.12.30.09.mp4
@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Block] Group Affects the Group Block labels Feb 24, 2022
@richtabor
Copy link
Member Author

As an aside, we also need a drop indicator for when you're dropping a block into a closed Group/Columns block. It's possible today to do that, but there's no visual indicating it so. Adding this here as it's related design wise.

@karmatosed karmatosed added the Needs Design Needs design efforts. label Feb 24, 2022
@paaljoachim

This comment was marked as outdated.

@richtabor

This comment was marked as outdated.

@paaljoachim
Copy link
Contributor

Looks good Rich!

Any additional feedback here @jasmussen Joen?

@annezazu
Copy link
Contributor

@paaljoachim Joen is on sabbatical right now just so this doesn't hold things up.

@paaljoachim
Copy link
Contributor

paaljoachim commented May 29, 2022

Great! Thanks for letting me know @annezazu

The method we have right now is consistent with the current UX method for drag and drop.
I believe we can move forward and add the label "Needs dev" and get this drag and drop method for the Group block in place.

@paaljoachim paaljoachim added Needs Dev Ready for, and needs developer efforts and removed Needs Design Needs design efforts. labels May 29, 2022
@nickfmc
Copy link

nickfmc commented Aug 5, 2022

this will be nice to have, after training people for the past 2 years on Gutenberg when handing over sites, I can say the biggest complaint I get is how bad the drag and drop UX is.

@paaljoachim
Copy link
Contributor

Hey @richtabor and @jasmussen
Let's get movement in this issue.
It would be great to get a PR in place and get the visual cue in for the empty Group block.

@richtabor
Copy link
Member Author

I updated the issue with more up-to-date visuals and its been added to the Polish board. Let's get this going. 🚀

@kevin940726 kevin940726 self-assigned this May 15, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 22, 2023
@priethor priethor removed [Status] In Progress Tracking issues with work in progress Needs Dev Ready for, and needs developer efforts labels May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Group Affects the Group Block [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants