Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Show the white appender/plus button when empty #38982

Closed
jasmussen opened this issue Feb 22, 2022 · 1 comment
Closed

Navigation: Show the white appender/plus button when empty #38982

jasmussen opened this issue Feb 22, 2022 · 1 comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

jasmussen commented Feb 22, 2022

When you insert a Navigation block and click "Start empty", it collapses to zero height because the container is empty (see also #38439).

empty

Additionally, if you unselect the block in this state, it becomes invisible so you might forget there's a navigation there at all.

We should do for an empty navigation block the same as the Row block does, show the white plus button in this state:

row

That way, there would both be something to indicate an empty block, but it would also avoid collapsing.

@jasmussen jasmussen added [Type] Enhancement A suggestion for improvement. [Block] Navigation Affects the Navigation Block labels Feb 22, 2022
@jasmussen
Copy link
Contributor Author

As of recent changes, the empty navigation block doesn't collapse as shown in the GIF above, and while it doesn't show the big white appender as suggested, in effect this solves the issue!
Screenshot 2022-04-27 at 23 46 21

Therefore, closing this one 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

1 participant