Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset duotone filters defined in theme.json per block #38504

Closed
ajlende opened this issue Feb 3, 2022 · 0 comments · Fixed by #39564
Closed

Unset duotone filters defined in theme.json per block #38504

ajlende opened this issue Feb 3, 2022 · 0 comments · Fixed by #39564
Assignees
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@ajlende
Copy link
Contributor

ajlende commented Feb 3, 2022

Description

It isn't currently possible to unset a duotone filter supplied via theme.json on a block, only override it with a different duotone filter.

I would expect that the 'clear' button resets the filter to whatever was set in the theme.json and there to be another option (a swatch or 'unset' button or something) to disable the filter for that specific image.

See earlier discussion in #34073 (comment)

Step-by-step reproduction instructions

  1. Activate a theme with a duotone value applied in theme.json
  2. In a post (or the site editor after Fix duotone rendering in site editor #37727 fixes rendering there) try to remove a filter from an image

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Feb 22, 2022
@ajlende ajlende self-assigned this Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants