Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a highlight border around empty parent blocks #38338

Open
heathergray opened this issue Jan 28, 2022 · 2 comments
Open

Add a highlight border around empty parent blocks #38338

heathergray opened this issue Jan 28, 2022 · 2 comments
Labels
[Block] Buttons Affects the Buttons Block [Type] Enhancement A suggestion for improvement.

Comments

@heathergray
Copy link

What problem does this address?

If I add a button block and then remove it, a parent block can be left behind. If I then save the changes and leave the page, when I go back in the button comes back on its own. I can check the list view or the breadcrumbs for empty parent blocks, but knowing that I need to, in that case, is tricky.

button-issue.mp4

What is your proposed solution?

If a border or highlight is added around an empty parent block so that it's obvious that it exists, then I can know to remove it. That would help a lot.

@aurooba has been discussing the issue with me

@aurooba
Copy link
Member

aurooba commented Jan 28, 2022

PR draft is ready ( #38337 ), for a simple fix for this situation! While a highlight or border would not follow the patterns in the Block Editor, we can add a visual cue by showing the Button Block Appender when the parent block is empty. :)

@annezazu
Copy link
Contributor

annezazu commented Feb 9, 2022

Hey folks! Neat to see this discussion. I've definitely run into this a few times myself. It's come up before in this issue where you can see some wider context: #28217 On the topic if highlighting blocks, this was an intentional decision and you can see a conversation about the considerations of that here: #23892

Definitely recommend checking out the above discussions to influence possible next steps.

@annezazu annezazu added [Block] Buttons Affects the Buttons Block [Type] Enhancement A suggestion for improvement. labels Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants