Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color circles should not use gray #37522

Closed
mtias opened this issue Dec 20, 2021 · 3 comments
Closed

Color circles should not use gray #37522

mtias opened this issue Dec 20, 2021 · 3 comments
Labels
[Feature] UI Components Impacts or related to the UI component system [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@mtias
Copy link
Member

mtias commented Dec 20, 2021

The color circles in global styles, palettes, and items should not be using static gray as borders but a shade of the main color. If we cannot use opacity because of how it's built we should generate it ourselves using the current color:

image
@mtias mtias added [Type] Bug An existing feature does not function as intended [Feature] UI Components Impacts or related to the UI component system labels Dec 20, 2021
@carolinan carolinan mentioned this issue Dec 20, 2021
Merged
@richtabor
Copy link
Member

I used the same mechanism we use elsewhere for colors in #37500.

@mtias
Copy link
Member Author

mtias commented Dec 20, 2021

Sweet!

@richtabor richtabor added the [Status] In Progress Tracking issues with work in progress label Dec 20, 2021
@aristath
Copy link
Member

Done in #37500 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] UI Components Impacts or related to the UI component system [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mtias @aristath @richtabor