Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duotone: when opening dropdown menus (e.g. duotone), tooltip shows up by default #37470

Open
simison opened this issue Dec 16, 2021 · 7 comments
Labels
[Block] Heading Affects the Headings Block [Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended

Comments

@simison
Copy link
Member

simison commented Dec 16, 2021

Description

When opening the duotone menu in an image block, the tooltip shows open by default:

image

Screen.Recording.2021-12-17.at.01.09.30.mov

Step-by-step reproduction instructions

  • Add image block
  • Add image
  • Click duotone icon
  • Note tooltip visible before you even move mouse over duotone options

Screenshots, screen recording, code snippet

No response

Environment info

  • WP 5.8
  • Gutenberg 12.0.2
  • Firefox

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

cc @mtias who noted this elsewhere.

@glendaviesnz glendaviesnz added [Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended labels Dec 17, 2021
@glendaviesnz
Copy link
Contributor

Confirmed that this still happens on WP 5.9 Beta 3 and latest Gutenberg trunk.

@mtias
Copy link
Member

mtias commented Dec 17, 2021

The more annoying part is the repositioning of the tooltip

@simison
Copy link
Member Author

simison commented Dec 19, 2021

This could be a more wider-spread issue? Just noticed the same with heading size dropdown when H1 gets autofocused:

Screenshot 2021-12-19 at 02 26 55

It was really annoying to try switching to H2 from H3.

@mtias
Copy link
Member

mtias commented Dec 20, 2021

Yes, it's widespread and has been there for a while.

@simison simison added the [Block] Heading Affects the Headings Block label Dec 21, 2021
@simison
Copy link
Member Author

simison commented Feb 8, 2022

I still saw this bug in dropdowns (WP 5.9 and Gutenberg 12.5.x), but not as consistently as before. It has somehow changed behaviour along the way.

Here's me trying to replicate:

Screen.Recording.2022-02-08.at.20.18.06.mov

@simison simison changed the title Duotone: when opening duotone menu, tooltip shows up by default Duotone: when opening dropdown menus (e.g. duotone), tooltip shows up by default Feb 9, 2022
@simison
Copy link
Member Author

simison commented Aug 26, 2022

The tooltip being visible might be side affect of another behavior described in older issue #26401

@jasmussen
Copy link
Contributor

Focus naturally lands on the first item in a popover. That'll announce it to screenreaders. But it isn't my understanding that this initial focus also needs to invoke the tooltip. Happy to be wrong here, from someone who knows with more confidence!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Heading Affects the Headings Block [Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants