Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same modal for creating new template parts in the editor and the template part list #37440

Closed
carolinan opened this issue Dec 16, 2021 · 2 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Template Editing Mode Related to the template editor available in the Block Editor

Comments

@carolinan
Copy link
Contributor

carolinan commented Dec 16, 2021

Description

When you create a new template part in the site or template editor you can only add a name. To add an area, you must go to the Advanced section in the block settings sidebar.
And when you create a new template part in the template part list in the site editor, you can add a name and choose the area.
The help text also differs.

I think the larger modal with the area selection should also be used in the site- and template editors.

Step-by-step reproduction instructions

  1. Activate a theme with support for full site editing or template editing
  2. Open the template part list in Appearance > Editor (beta), and select the Add new button to create a new template part.
  3. Now go to the template editor via the block editor, or to the site editor, and create a new template part, and compare the experience.

Screenshots, screen recording, code snippet

In the editors, replace
template-part-block-name-new-part

With
template-part-block-site-editor-create-new

Environment info

Gutenberg trunk,
WordPress 5.9.0 beta 3 via the beta tester plugin

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

@carolinan carolinan added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Template Editing Mode Related to the template editor available in the Block Editor labels Dec 16, 2021
@carolinan
Copy link
Contributor Author

@jameskoster Also, looking at the screenshots above -are two cancel / close buttons needed here? I have not noticed it before.

@jameskoster
Copy link
Contributor

I think this could be a good enhancement, but there is a lot to consider. For example how can we make better use of patterns as a part of the creation flow for headers and footers? And how can we streamline the insertion flow for existing template parts? Relying on the monolithic "Template part" block for all these flows doesn't seem very efficient or intuitive.

Just to connect some dots – I explored some concepts around these ideas in:

I would love to hear any feedback on those issues.

are two cancel / close buttons needed here? I have not noticed it before.

Probably not :)

@carolinan carolinan closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Template Editing Mode Related to the template editor available in the Block Editor
Projects
None yet
Development

No branches or pull requests

2 participants