Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve treatment of the "Template Part Not Found" message #37222

Closed
kjellr opened this issue Dec 8, 2021 · 6 comments · Fixed by #37404
Closed

Improve treatment of the "Template Part Not Found" message #37222

kjellr opened this issue Dec 8, 2021 · 6 comments · Fixed by #37404
Assignees
Labels
Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@kjellr
Copy link
Contributor

kjellr commented Dec 8, 2021

When there's an error with a theme's template part, the site displays a message like this:

Screen Shot 2021-12-08 at 8 12 42 AM

This is helpful for development, but it's also a very confusing thing to show to users. Can we adjust this so that it fails more gracefully? (In my testing, this message appears whether or not WP_DEBUG is on or off)

@kjellr kjellr added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. labels Dec 8, 2021
@talldan
Copy link
Contributor

talldan commented Dec 14, 2021

@kjellr I made an issue related to this too - #36510, it might be possible to close one of them as a duplicate.

The message doesn't seem to work when I test it, but maybe that depends on what kind of template part it is (file vs post). It looks like I'm testing the latter and you're testing the former.

@talldan
Copy link
Contributor

talldan commented Dec 14, 2021

BTW, my instinct was that the block could show its placeholder instead of the message so that a user can at least pick a different template part, but there might be other options.

@kjellr
Copy link
Contributor Author

kjellr commented Dec 14, 2021

Hmm. These seem similar, but might be slightly different? In the case here, I'm mostly concerned about these messages showing up to front-end visitors.

@talldan
Copy link
Contributor

talldan commented Dec 15, 2021

Yes, I didn't quite catch that this was on the front-end of the site. 👍

Do you think this should be fixed for 5.9? My feeling is that it probably should be, so I'll add it to the project board.

@kjellr
Copy link
Contributor Author

kjellr commented Dec 15, 2021

Yeah, I think it should be. Thank you!

@Mamaduka
Copy link
Member

@kjellr, PR is ready for the review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants