Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LineHeightControl: Replace internal implementation with NumberControl #37110

Closed
Tracked by #36230
mirka opened this issue Dec 3, 2021 · 0 comments · Fixed by #37160
Closed
Tracked by #36230

LineHeightControl: Replace internal implementation with NumberControl #37110

mirka opened this issue Dec 3, 2021 · 0 comments · Fixed by #37160
Assignees
@mirka
Labels
[Feature] Component System WordPress component system [Package] Block editor /packages/block-editor [Status] In Progress Tracking issues with work in progress

Comments

@mirka
Copy link
Member

mirka commented Dec 3, 2021 •
edited
Loading

LineHeightControl internally uses TextControl. This can be migrated to NumberControl for code simplification, styling consistency, and to benefit from features in NumberControl like dragging.
@mirka mirka mentioned this issue Dec 3, 2021
Closed
7 tasks
@mirka mirka changed the title ❓ Replace LineHeightControl implementation with NumberControl 🧪 LineHeightControl: Replace internal implementation with NumberControl Dec 3, 2021
@mirka mirka self-assigned this Dec 3, 2021
@mirka mirka added the [Feature] Component System WordPress component system label Dec 3, 2021
@mirka mirka mentioned this issue Dec 3, 2021
Closed
7 tasks
@mirka mirka added the [Package] Block editor /packages/block-editor label Dec 3, 2021
@mirka mirka mentioned this issue Dec 6, 2021
Merged
10 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirka mirka

Labels
[Feature] Component System WordPress component system [Package] Block editor /packages/block-editor [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
1 participant
@mirka