Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - Include a couple of reference blocks #3693

Closed
danielbachhuber opened this issue Nov 28, 2017 · 9 comments
Closed

Docs - Include a couple of reference blocks #3693

danielbachhuber opened this issue Nov 28, 2017 · 9 comments
Assignees
Labels
[Type] Developer Documentation Documentation for developers

Comments

@danielbachhuber
Copy link
Member

As a Gutenberg extender, it would be helpful to have at least a couple full-featured reference blocks to review.

When producing these reference blocks, it would be most effective to consider them from the perspective of the reader (e.g. "here's how to implement a shortcode as a block" and "here's how to implement a metabox as a block").

From wp-cli/scaffold-command#88 (comment)

@youknowriad youknowriad added the [Type] Developer Documentation Documentation for developers label Nov 28, 2017
@youknowriad
Copy link
Contributor

youknowriad commented Nov 28, 2017

We already have some ready to use blocks here https://github.com/WordPress/gutenberg-examples
And they are used in the create blocks tutorial.

We could use some more advanced examples though (like the meta block)

@NewJenk
Copy link

NewJenk commented Nov 28, 2017

Yes, please include some advanced blocks, e.g. a menu block where the user selects a WP menu and the menu is then displayed.

@gziolo gziolo self-assigned this Nov 28, 2017
@wpalchemist
Copy link

The blocks in the gutenberg-examples repo don't work, and neither does the code in the "create blocks" tutorial. The code examples are all out of date and need to be updated to keep up with Gutenberg development.

@youknowriad
Copy link
Contributor

@wpalchemist True, We'd love some help from the community when possible of course. There's too much work to do and helping with the docs seems like a good way to start contributing.

@wpalchemist
Copy link

@youknowriad I would love to contribute here, but I don't know how to make any of those code examples work. There's a chicken-and-egg problem: I would be happy to write some documentation, but without any documentation, I don't have enough information to write anything. I've tried reading through the codebase to see if I can figure out what needs to go into the documentation, but it's really hard to just dive in there.

@youknowriad
Copy link
Contributor

@wpalchemist I understand, we should try to keep the docs up to date while we update the API. I think we've successfully done this for most of the docs except the block examples which are harder to keep in sync.

I appreciate the intent though and if you ever feel adventurous and have questions about some "errors" in the examples or any other API, feel free to reach out (slack, github or whatever)

@mboynes
Copy link
Contributor

mboynes commented Dec 6, 2017

@wpalchemist @youknowriad I fixed the examples in https://github.com/WordPress/gutenberg-examples. They still deviate from the create blocks tutorial, but at least they're working now.

@wpalchemist
Copy link

Thank you, @mboynes! That's very helpful! I'm hoping to have time in the next few weeks to work on the documents, but I have some other projects with deadlines so I'm not sure how much time I'll have.

@danielbachhuber
Copy link
Member Author

Both the Gutenberg Examples and main wordpress/gutenberg/docs directories have a good set of examples to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

No branches or pull requests

6 participants