Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift+Click in grouped blocks locks editor #36683

Closed
BushnellWebWorks opened this issue Nov 19, 2021 · 3 comments
Closed

Shift+Click in grouped blocks locks editor #36683

BushnellWebWorks opened this issue Nov 19, 2021 · 3 comments
Labels
[Feature] Block Multi Selection The ability to select and manipulate multiple blocks

Comments

@BushnellWebWorks
Copy link

Description

When a block having child elements (such as "core/table" or "core/list") is grouped with one or more other components, shift+clicking across child elements within the block, prevents further editing on any blocks.

Step-by-step reproduction instructions

  1. Start with a block editor panel having at least one paragraph
  2. Add two blocks, one having child elements (consistently happens with "core/list" or "core/table")
  3. Group them
  4. Inside the block with child elements, shift+click from one child to another

At this point it becomes impossible to update content in any blocks within the editor. For example, cannot click within a paragraph and add text.

  • First noticed the issue with WP 5.8, not an issue with WP 5.7.2
  • Issue persists in WP 5.8.2
  • First uncovered the issue in a custom block using , but can reproduce without code using the above steps

Screenshots, screen recording, code snippet

Hard to convey "can't edit" within this recording, but after I shift+click within the "core/list" block then I try to click and type within other blocks.

just_the_wp58_bug

Environment info

  • WordPress 5.8, bug also confirmed in WordPress 5.8.2 (but not present in 5.7.2)
  • Custom Theme

Browsers:

  • Chrome Version 96.0.4664.55 (Official Build) (x86_64)
  • Edge Version 95.0.1020.53 (Official build) (x86_64)
  • Safari Version 14.1 (16611.1.21.161.6)

OS:
Mac 11.3.1
(also verbally confirmed with Windows users, versions unknown)

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@talldan
Copy link
Contributor

talldan commented Nov 23, 2021

Hi @BushnellWebWorks, thanks for reporting this. I think this was fixed in the Gutenberg plugin, and the fix should be in WordPress 5.9.

It looks like one or both of these pull requests solved the problem:

Lets check in with @ntsekouras to make sure though.

@talldan talldan added the [Feature] Block Multi Selection The ability to select and manipulate multiple blocks label Nov 23, 2021
@ntsekouras
Copy link
Contributor

Thanks for the issue @BushnellWebWorks.

Lets check in with @ntsekouras to make sure though.

Yes, this is fixed in the plugin and will be in WP 5.9 as @talldan said.

@BushnellWebWorks
Copy link
Author

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Multi Selection The ability to select and manipulate multiple blocks
Projects
None yet
Development

No branches or pull requests

3 participants