Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify classic templates work as a fallback to block ones #36615

Closed
priethor opened this issue Nov 18, 2021 · 3 comments
Closed

Verify classic templates work as a fallback to block ones #36615

priethor opened this issue Nov 18, 2021 · 3 comments
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Needs Testing Needs further testing to be confirmed. [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended

Comments

@priethor
Copy link
Contributor

Description

For the WordPress 5.9 release, we need to ensure themes can work in a hybrid mode so that they load block themes when available but can also use PHP ones as a fallback. For example, a block theme with an archive PHP template but no HTML one should be able to find and use the PHP template.

Step-by-step reproduction instructions

  1. Install a block theme.
  2. Create two versions of the archive template, both in classic PHP and as a blocks template.
  3. Verify the block template is being used.
  4. Delete the block template, leaving only the PHP one.
  5. Verify the classic template is used.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@priethor priethor added [Type] Bug An existing feature does not function as intended Needs Testing Needs further testing to be confirmed. [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Feature] Full Site Editing labels Nov 18, 2021
@priethor priethor changed the title Verify classic templates are used as a fallback for block ones Verify classic templates work as a fallback to block ones Nov 18, 2021
@skorasaurus
Copy link
Member

there is an issue for this already at #24834

@skorasaurus skorasaurus added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label Nov 18, 2021
@skorasaurus
Copy link
Member

skorasaurus commented Nov 18, 2021

on second thought, I am reopening because this is on the 5.9 must haves board and don't have edit access to that; but should consolidate discussion of this into #24834 ; close this issue and then update the 5.9 board with that issue

@skorasaurus skorasaurus reopened this Nov 18, 2021
@priethor
Copy link
Contributor Author

Closing as duplicate of #24834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Needs Testing Needs further testing to be confirmed. [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants