Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Site Logo placeholder treatment to Featured Image block #36136

Closed
jameskoster opened this issue Nov 2, 2021 · 3 comments · Fixed by #36517
Closed

Apply Site Logo placeholder treatment to Featured Image block #36136

jameskoster opened this issue Nov 2, 2021 · 3 comments · Fixed by #36517
Labels
[Block] Post Featured Image Affects the Post Featured Image Block Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Recently we enhanced the placeholder for the Site Logo block: #35397

It would be neat to apply something similar to the Featured Image block as well. We can't quite do a 1:1 replication, as the Featured Image needs to entertain more contexts, which I'll outline below.

Editing a template – no content

If you simply open something like the Page template in the site editor, you see the raw blocks that compose that template:

Screenshot 2021-11-02 at 09 40 09

In this context, we can use the Site Logo placeholder appearance (the dashed illustration), but it should not be possible to set the featured image.

Editing a template – with content – no featured image set

If you edit a page (or post) that has no featured image set in the post editor, then navigate to edit the template via the "Template" panel in the Inspector, you should also see the dashed illustration. However in this scenario it should be possible to set the featured image.

Editing a template – with content – featured image set

If you edit a page (or post) that has a featured image set in the post editor, then navigate to edit the template via the "Template" panel in the Inspector, you should simply see whatever featured image is set on the canvas. Like the Site Logo it should be possible to replace or unset the image.

@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. [Feature] Full Site Editing [Block] Post Featured Image Affects the Post Featured Image Block labels Nov 2, 2021
@noisysocks noisysocks added the Needs Dev Ready for, and needs developer efforts label Nov 3, 2021
@noisysocks
Copy link
Member

Not sure how much work is involved here. If it's easy then let's get it in for WP 5.9. If not then let's drop it from the "Must haves" board and work on it in the plugin.

@annezazu
Copy link
Contributor

As part of this effort, it would be neat if the duotone filters applied to the placeholder as well based on the feedback on trying to add the featured image block and a duotone filter in a template in the eleventh FSE outreach program call for testing:

I found it a bit strange adding a featured image block and a duotone filter without seeing what the result would look like.

@jasmussen
Copy link
Contributor

PR here: #36517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Featured Image Affects the Post Featured Image Block Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants