Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11: Gallery block doesn't show #3586

Closed
2 tasks
tg-ephox opened this issue Nov 21, 2017 · 8 comments
Closed
2 tasks

IE11: Gallery block doesn't show #3586

tg-ephox opened this issue Nov 21, 2017 · 8 comments
Assignees
Labels
Browser Issues Issues or PRs that are related to browser specific problems Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended
Milestone

Comments

@tg-ephox
Copy link
Contributor

Issue Overview

Gallery block doesn't appear, works correctly though. Can upload an image and view it in another browser.

Steps to Reproduce (for bugs)

  1. Add Gallery block
  2. Upload Image

Doesn't show

Expected Behavior

Displays as in other browers.

Current Behavior

Doesn't display.

Possible Solution

Probably CSS issue

Screenshots / Video

screen shot 2017-11-21 at 5 02 05 pm
The Gallery block is the last block that is cut off.

Related Issues and/or PRs

Todos

  • Tests
  • Documentation
@tg-ephox tg-ephox added the [Type] Bug An existing feature does not function as intended label Nov 21, 2017
@youknowriad youknowriad added the Browser Issues Issues or PRs that are related to browser specific problems label Nov 21, 2017
@aduth
Copy link
Member

aduth commented Nov 21, 2017

Not yet having looked into it, but knowing Gallery block leverages Flexbox, there are a number of IE11-specific Flexbox bugs, many of which have workarounds, documented here:

https://github.com/philipwalton/flexbugs

@karmatosed karmatosed added this to the Merge Proposal milestone Jan 25, 2018
@jorgefilipecosta jorgefilipecosta self-assigned this Mar 22, 2018
@jeffpaul
Copy link
Member

This ticket was mentioned in Slack in #core-editor by jeffpaul. View the logs.

@jeffpaul jeffpaul added the Needs Testing Needs further testing to be confirmed. label Mar 22, 2018
@jorgefilipecosta
Copy link
Member

The crash is not happening but the block still have problems in IE11.

@aduth
Copy link
Member

aduth commented Mar 29, 2018

@jorgefilipecosta Can you enumerate the problems?

I had seen in some brief testing that there was significant unexpected vertical stretch of images in IE11.

@jorgefilipecosta
Copy link
Member

I had seen in some brief testing that there was significant unexpected vertical stretch of images in IE11.

Yes, that's it the images get stretched:
screen shot 2018-03-29 at 15 17 26
In the front end the problem also happens.

@jorgefilipecosta
Copy link
Member

But no crash at all, not certain If we should close the issue in this case, as the crash was probably caused by other problem that as fixed meanwhile.

@aduth
Copy link
Member

aduth commented Mar 29, 2018

Is the other issue tracked?

@jorgefilipecosta
Copy link
Member

Yes, it is #5504.
So I'm closing this issue for now.
Thank you @tg-ephox for reporting this issue, it was probably solved as a side effect of other change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

6 participants