Series of bugs and shortcomings faced during 5.9 go/no go prep

[mtias]

Compiling a list of bugs, shortcomings, and enhancement ideas I run into when preparing for the go / no go demo.

• Switch the Page List block to client-side rendering #35632

There's a lot of small issues related to the roundtrip a ServerRender block needs to do for any change and a great showcase for why they should be avoided entirely for any interactive block.

Screeny.Video.14.Oct.2021.at.12.29.46.mov

• Pressing shift + click within a rich-text block nested inside a group would lock you out of editing. This one is pretty frustrating.([Block Editor]: Fix selection by holding shift key for nested blocks #35668)

Screeny.Video.14.Oct.2021.at.18.41.39.mov

• Navigation block new link would break with no visible signs of recovery — typing the name of the page would not bring the page up.

Generally can happen after leaving the page open for a little bit or interacting for a while. It's understandable connection might break, but there should be some feedback.

• Components: ColorPicker "vibrates" when moving the circle slowly #35675
• Components: ColorPicker closes randomly on occasions when trying to interact with it #35677

Screeny.Video.13.Oct.2021.at.20.28.05.mov

• Site logo placeholder graphic is not rendered properly in the site editor.
• The template dropdown has template parts with no names when they don't belong to an area. Reported in When editing a template part in isolation the Areas UI is surfacing general template parts #35587.

• Buttons inside groups are misaligned. (Might be theme related.)

• Disabling theme editor styles in preferences makes some elements in the page load with default colors and not the current color scheme.

• The sibling inserter repositioning, together with the animation, makes it jump around.

Screeny.Video.14.Oct.2021.at.18.31.43.mov

---

• The amount of lines shown in the site editor to distinguish active focus, hover focus, current template part focus, etc, is wild. We need to reduce this.

• There's also a weird dotted outline on the site block.

• More blocks with dotted outlines that don't seem appropriate.

• Search in navigation menus is super awkward. It should be possible to get an icon only button that expands inline or in an overlay. This should likely also be the default. The initial insertion state, in particular, is a terrible experience (Search: Hide label when inserted in Navigation block #36026):

• Menu settings (called Display) should come before the Typography supports and should probably not be in a panel at all (not collapsible).

• Typography: default size looks "unset".

[MaggieCabrera]

There's also a weird dotted outline on the site block.

I suspect that is a Videomaker bug /cc @scruffian

[ntsekouras]

Typography: default size looks "unset".

Could we use a help text here if we have ToggleGroupControl and the value is set to default?

[scruffian]

Buttons inside groups are misaligned. (Might be theme related.)

This was fixed by Automattic/themes#4842

[jasmussen]

Site logo fixed in #35718.

The amount of lines shown in the site editor to distinguish active focus, hover focus, current template part focus, etc, is wild. We need to reduce this.

#35637 removes dotted lines on ancestors. That fixes, or starts work on it.

Search in navigation menus is super awkward. It should be possible to get an icon only button that expands inline or in an overlay. This should likely also be the default.

#35688 starts work on it. The issue is also tracked separately in #31127.

[youknowriad]

Disabling theme editor styles in preferences makes some elements in the page load with default colors and not the current color scheme.

I've been trying but failing to reproduce this one. Any more details?

[jasmussen]

I've been trying but failing to reproduce this one. Any more details?

I'm seeing it happen in my block theme when toggling the editor styles off in preferences:

[noisysocks]

Pages List server-render component is ill-suited and needs to be converted to a proper editor block.

I can look into this.

[tellthemachines]

Navigation block new link would break with no visible signs of recovery — typing the name of the page would not bring the page up.

Not sure how to reproduce this one, or even what's happening. Could we have more detailed steps please?

[noisysocks]

Menu settings (called Display) should come before the Typography supports and should probably not be in a panel at all (not collapsible).

Fixed by #33744.

[jasmussen]

The amount of lines shown in the site editor to distinguish active focus, hover focus, current template part focus, etc, is wild. We need to reduce this.

Checked this one, as fixed by #35637. I suspect additional fixes can be made, but it fixed the immediate issue.

[mtias]

This is mostly covered, thanks for the work following up on issues!