Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in applied feedback messages #3461

Closed
karmatosed opened this issue Nov 13, 2017 · 3 comments
Closed

Add in applied feedback messages #3461

karmatosed opened this issue Nov 13, 2017 · 3 comments
Labels
[Feature] NUX Anything that impacts the new user experience Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@karmatosed
Copy link
Member

This is an exploration of the idea suggested by @hedgefield and builds on from the messages work in #3457.

Let's consider having feedback messages when something is applied. Some good cases for this would be:

  • Links
  • Captions
  • Buttons..

Possible placing for these:

In top bar: this is the least elegant solution in my opinion

1

Beside the action: not sure this scales for all cases

2

Underneath the action: this possibly is a better format

3

Let's research and consider before we design

  • Where should the message go?
  • Are there any existing patterns in core we can use for this?
  • If there are no existing, what are some examples design wise of this in other applications?
@mtias
Copy link
Member

mtias commented Nov 14, 2017

Why do we need messages for these actions? I think messages should be used for important async calls, like updating and saving a post or a global block. The success message for applying a link should be that the link shows.

@hedgefield
Copy link

For links this isn't such a problem, but the Button block does not distinguish between an entered URL and an applied URL. Pressing Enter or the Apply button does not give any feedback. That's confusing. A whole message might be a bit intense, but at least the button should change styling/become hidden/display a checkmark to show that what you did had an impact. See #3427 (comment) for context.

@mtias mtias added the Needs Design Feedback Needs general design feedback. label Jan 18, 2018
@jeffpaul jeffpaul added [Type] Enhancement A suggestion for improvement. [Feature] NUX Anything that impacts the new user experience labels Jan 19, 2018
@jeffpaul jeffpaul added this to the Nice To Have milestone Jan 19, 2018
@karmatosed karmatosed modified the milestones: Nice To Have, Merge Proposal Jan 25, 2018
@karmatosed
Copy link
Member Author

Let's close and look at auditing messages as a group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] NUX Anything that impacts the new user experience Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants