-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show changes to padding when entering changes in dimensions panel #34468
Comments
Thanks for the ping @annezazu 🙂 The behaviour shown is consistent with the implementation of the I'm not aware of the history behind this decision or if it's still valid. I'd suspect there was a valid reason for it, perhaps @jasmussen can shed more light on that from a UX perspective? After quickly removing that flag, an initial test following the video appeared to work ok. It could lead to a pretty jumpy experience updating on every keystroke though. I think I personally prefer the "press enter to change" behaviour. I make a broad edit say to something like |
Thank you for the great context! I find the differences in experiences a bit jarring/confusing but I can also see why it's implemented as it is. Either way, I couldn't quite tell if this was a bug or future but will trust the design expertise Joen brings on this one. |
Very helpful context as well. I sense and suspect there are some accessibility considerations related to having to press enter when you manually type in numbers. It could perhaps even be related to performance, where if you accidentally type 10000 it might choke for a bit. Worth noting we do have some affordances to make this experience nicer, including the fact that you can use up and down arrows to increment/decrement the padding by 1, or shift up/down to increment/decrement by 10. You can also drag upwards and downwards in the panel itself: Finally there's #33221 which details an effort to adjust the padding in the canvas itself. All of these should mitigate the specific issue. |
Thank you for the extra details and for following up! Love how much one can learn in opening issues.
^ I think these exact affordance are part of why I expect being able to enter values to work in the same way. I agree though that the contextual padding controls very much will resolve this. Closing out the issue as a result. |
What problem does this address?
This came up as part of the ninth call for testing with the FSE Outreach Program:
Essentially, unless you're dragging up and down to change values, changing the value doesn't show a change in the editor. Tied to this, if one empties the value, it resets to the prior one (bug or feature?). Here's a quick video:
padding.mov
What is your proposed solution?
When manually entering a value, have the changes be reflected in the editing experience. cc @aaronrobertshaw @jasmussen for thoughts since I can see you all are working on this!
The text was updated successfully, but these errors were encountered: