Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift-select in a group block doesn't select anything #33665

Closed
MVColombie opened this issue Jul 23, 2021 · 2 comments · Fixed by #35668
Closed

Shift-select in a group block doesn't select anything #33665

MVColombie opened this issue Jul 23, 2021 · 2 comments · Fixed by #35668
Labels
[Block] Group Affects the Group Block [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended

Comments

@MVColombie
Copy link

MVColombie commented Jul 23, 2021

Description

Impossible to edit text after selecting several words with SHIFT key.

Step-by-step reproduction instructions

  1. Make a "group" with a text block;
  2. Try to select several words using SHIF key

Expected behaviour

Be able to do something, delete selected text, edit text block, etc.

Actual behaviour

It's freezing the block and all blocks around. Impossible to edit nothing.

Screenshots or screen recording (optional)

ezgif com-video-to-gif

Code snippet (optional)

WordPress information

  • WordPress version: 5.8
  • Gutenberg version:
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? Yes 2021

Device information

  • Device: Desktop
  • Operating system: Mac OS Big Surr 11.2.2
  • Browser: FireFox 90.0.2
@MVColombie MVColombie changed the title Enable to edit text after selecting several words with SHIFT key. Impossible to edit text after selecting several words with SHIFT key. Jul 23, 2021
@Mamaduka Mamaduka added [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable Needs Testing Needs further testing to be confirmed. labels Jul 26, 2021
@johngodley
Copy link
Contributor

johngodley commented Aug 2, 2021

I can confirm that using the shift key inside a group doesn't work. It doesn't freeze anything for me, or cause any subsequent problems, and once I release the shift key I can continue editing. However, given that shift-select works outside of a group then it seems something in need of attention.

@johngodley johngodley added [Type] Bug An existing feature does not function as intended [Block] Group Affects the Group Block and removed Needs Testing Needs further testing to be confirmed. labels Aug 2, 2021
@johngodley johngodley changed the title Impossible to edit text after selecting several words with SHIFT key. Shift-select in a group block doesn't select anything Aug 2, 2021
@them-es
Copy link
Contributor

them-es commented Oct 20, 2021

This issue should be solved once #35668 has been merged 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Group Affects the Group Block [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants