Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy Widget: NoPreview component has extraneous padding #33124

Closed
noisysocks opened this issue Jul 1, 2021 · 5 comments
Closed

Legacy Widget: NoPreview component has extraneous padding #33124

noisysocks opened this issue Jul 1, 2021 · 5 comments
Labels
[Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets CSS Styling Related to editor and front end styles, CSS-specific issues. [Type] Bug An existing feature does not function as intended

Comments

@noisysocks
Copy link
Member

Description

When you insert a Legacy Widget block, the default placeholder has some styling issues.

Expected behaviour

  • The "Select a legacy widget to display" text should not be truncated.
  • The "Select widget" text should be sans-serif.

Screenshots or screen recording

Screen Shot 2021-07-01 at 14 20 01

WordPress information

5.8 RC 1 with no Gutenberg Plugin.

@noisysocks noisysocks added [Type] Bug An existing feature does not function as intended [Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets CSS Styling Related to editor and front end styles, CSS-specific issues. labels Jul 1, 2021
@noisysocks
Copy link
Member Author

noisysocks commented Jul 1, 2021

Also looks like the input labels ("Title" below) are serif again which I thought we'd fixed? Maybe it was a recent fix or a PR was not backported. @tellthemachines

Screen Shot 2021-07-01 at 14 28 40

@noisysocks
Copy link
Member Author

noisysocks commented Jul 1, 2021

Also the title ("Text" below) in the "No preview available" message is large and has too much padding. More CSS bleed no doubt 😅

Screen Shot 2021-07-01 at 14 32 27

The video in #30889 shows how it should look.

@tellthemachines
Copy link
Contributor

I think this is expected behaviour. The font-family in those fields is set to system-ui, and Firefox's default font for some reason is Times. You can go into browser settings and change it:

Screen Shot 2021-07-01 at 4 21 48 pm

Not sure where the padding on the title is coming from though, that's probably on our side 😅

@noisysocks
Copy link
Member Author

I think this is expected behaviour. The font-family in those fields is set to system-ui, and Firefox's default font for some reason is Times. You can go into browser settings and change it:

OK fair enough!

It looks like @adamziel fixed the truncation in #33141 so let's just fix the NoPreview component's styling issues:

It should look like it did in #30889:

Screen Shot 2021-07-05 at 11 26 54

@noisysocks noisysocks changed the title Legacy Widget: Placeholder text is truncated, dropdown has serif font Legacy Widget: NoPreview component has extraneous padding Jul 5, 2021
@adamziel
Copy link
Contributor

adamziel commented Jul 5, 2021

Fix available in #33200

@adamziel adamziel closed this as completed Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets CSS Styling Related to editor and front end styles, CSS-specific issues. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants