Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-plugin-zip.sh doesn't include *.js files #32050

Closed
bph opened this issue May 20, 2021 · 5 comments · Fixed by #31917
Closed

build-plugin-zip.sh doesn't include *.js files #32050

bph opened this issue May 20, 2021 · 5 comments · Fixed by #31917
Assignees
@vcanales
Labels
[Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling

Comments

@bph
Copy link
Contributor

bph commented May 20, 2021 •
edited
Loading

A user of today's Gutenberg nightly detected a missing files issue

"the front end is looking for plugins/gutenberg-nightly/build/block-library/blocks/navigation/frontend.js
And throws a 404 error.

Turns out the build-plugin-zip.sh doesn't include *.js files
Screen Shot 2021-05-20 at 11 04 35 AM

Thanks to @bobbingwide and @gziolo for troubleshooting this with me.
@gziolo gziolo added this to the Gutenberg 10.7 milestone May 20, 2021
@gziolo gziolo added [Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling [Priority] High Used to indicate top priority items that need quick attention labels May 20, 2021
@youknowriad
Copy link
Contributor

cc @vcanales @jasmussen

@vcanales
Copy link
Member

Thanks for the heads up — fix is waiting to be merged here.

I'd appreciate some eyes, since checks have been refusing to run, and/or fail randomly.

@jasmussen
Copy link
Contributor

@youknowriad does the above fix need to be in the RC?

bph added a commit to bph/gutenberg that referenced this issue May 20, 2021
@bph
fix WordPress#32050
87f4320
@bph bph mentioned this issue May 20, 2021
Closed
@gziolo
Copy link
Member

gziolo commented May 20, 2021 •
edited
Loading

@vcanales, this fix is not enough. The file needs to be listed in the script that builds the zip file.

@vcanales
Copy link
Member

@vcanales, this fix is not enough. The file needs to be listed in the script that builds the zip file.

👍 indeed it looks like it's a two parter. I can add that change to the PR waiting to be merged.

@gziolo gziolo mentioned this issue May 20, 2021
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 20, 2021
@bph bph removed their assignment May 20, 2021
@vcanales vcanales self-assigned this May 20, 2021
vcanales added a commit that referenced this issue May 20, 2021
@vcanales
Correctly read rawRequest for frontend ESM (#31917)
48137eb 
Fixes: #31909
Fixes: #32050
@gziolo gziolo removed this from the Gutenberg 10.7 milestone May 21, 2021
youknowriad pushed a commit that referenced this issue May 26, 2021
@vcanales @youknowriad
Correctly read rawRequest for frontend ESM (#31917)
b87c366 
Fixes: #31909
Fixes: #32050
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vcanales vcanales

Labels
[Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Milestone
No milestone
5 participants
@bph @youknowriad @gziolo @vcanales @jasmussen