Add Block: Embed

[mtias]

Attributes

• Alignment: None, Left, Right, Center, Full Bleed.
• Change url.

Markup

<!-- wp:embed -->
http://embedurl
<!-- /wp -->

States (see all)

[aduth]

What's the markup of an embed block which has a caption assigned?

[mtias]

@jasmussen thoughts on caption there? I'm thinking it doesn't make sense to support caption in a generic embed block. It'd be fine on a specific video block, though.

[ellatrix]

Why would it not?

[jasmussen]

I'm thinking it doesn't make sense to support caption in a generic embed block. It'd be fine on a specific video block, though.

So long as I can make a linebreak, center and italicize some text, I don't have strong opinion.

I think in general, it makes sense for media items, but if you embed something and the resulting block is something non media related, yeah probably would feel weird with a caption.

[mtias]

Yes, that's my hesitance, it'd feel spurious in some embeds and adds some visual and cognitive weight.

[ellatrix]

Somehow, I do like that all "object blocks" would have the same markup and caption support.

<figure>
  <!-- children -->
  <figcaption>Caption.</figcaption>
<figure>

Whether it's an image, gallery, embed, table, or other form of data visualisation.

[ellatrix]

In the case of oEmbed, this could still be the link to the resource. It's valid to store it in a figure, and it comes with some handy things like floating.

<figure>https://www.youtube.com/watch?v=Nl6U7UotA-M</figure>

<figure class="alignright">
  https://www.youtube.com/watch?v=Nl6U7UotA-M
  <figcaption>Caption.</figcaption>
<figure>

[jasmussen]

I think you both make really solid arguments here.

Can we "wait and see what feels right" on this one? Or are there other ways we can get closer to a consensus? Do we have a list of all supported oembeds? Maybe we can look at the list and see if a whole bunch of them would look super weird with captions, and decide from that.

[mtias]

I don't have a strong opinion here :)

[jasmussen]

Can we close this one as fixed now that the embed block is in?

[StaggerLeee]

Maybe I am just a bit lazy, but I cannot see option to insert/embed video from local server ?
I mean upload to Media Library, and chose it same way as image/gallery.