Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block: Placeholder text squished in template editing mode #31352

Closed
annezazu opened this issue Apr 29, 2021 · 7 comments · Fixed by #31371
Closed

Navigation Block: Placeholder text squished in template editing mode #31352

annezazu opened this issue Apr 29, 2021 · 7 comments · Fixed by #31371
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Description

When using template editing mode and a new navigation block that hasn't yet been configured, the placeholder texts is squished. cc @jasmussen

Step-by-step reproduction instructions

  1. Create a post.
  2. Enter template editing mode with a template that does not have a navigation block configured.
  3. Click into navigation block and see the text is squished

Expected behaviour

Expect the placeholder text to be more responsive in template editing mode.

Actual behaviour

The text doesn't scale well/getes smushed

Screenshots or screen recording (optional)

Screen Shot 2021-04-29 at 12 45 20 PM

WordPress information

  • WordPress version: 5.7.1
  • Gutenberg version: 10.5.2
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? TT1 Blocks
@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels Apr 29, 2021
@annezazu
Copy link
Contributor Author

Working on a demo so running into more oddities and noting that this happens too:

Screen Shot 2021-04-29 at 12 50 47 PM

@jasmussen
Copy link
Contributor

Thank you. For a little more context, the placeholder lacks the responsive classes other placeholders can leverage to minimize the content when shown in constrained contexts. I'll take a look!

@jasmussen
Copy link
Contributor

There's a fix for this one in #31371.

@annezazu
Copy link
Contributor Author

annezazu commented May 6, 2021

Noting for now that I am seeing this in 10.6 RC:

Screen Shot 2021-05-06 at 12 25 15 PM

@jasmussen
Copy link
Contributor

Yep, I'm afraid the PR didn't land in time for 10.6. It's milestoned for 10.7:

Screenshot 2021-05-07 at 09 28 48

@annezazu
Copy link
Contributor Author

annezazu commented May 7, 2021

Ah! Bummer. I thought it was in for 10.6. Apologies!

@jasmussen
Copy link
Contributor

Not at all. Pity we missed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants