Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine border control panel with design tools #31337

Closed
7 tasks
jameskoster opened this issue Apr 29, 2021 · 15 comments
Closed
7 tasks

Refine border control panel with design tools #31337

jameskoster opened this issue Apr 29, 2021 · 15 comments
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Design Feedback Needs general design feedback. [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Apr 29, 2021

Now that we have border controls (#30124 🎉) I took a little time to explore how we might apply some of the concepts outlined in #27331 to refine the UX here a bit.

Some of the suggestions can be implemented now, others will require underlying components that are yet to be built.

Here's a before / after, and a list of the changes:

Screenshot 2021-04-29 at 13 48 32

@jameskoster jameskoster added Needs Design Feedback Needs general design feedback. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. labels Apr 29, 2021
@karmatosed
Copy link
Member

Goodness this is significantly better to interact with visually, great work. My initial thought after feeling it's just a lot easier to process is that perhaps the order is something to iterate on? I wonder for example if color would come as the last still in the list? Beyond that, I think it's a great iteration.

@paaljoachim
Copy link
Contributor

paaljoachim commented May 4, 2021

Looking at the Cover block to see how it handles Padding of all sides compared to manually unlocking individual side adjustments.

Screen Shot 2021-05-04 at 18 10 33

Here one clicks the lock. (Tool tip is seen.)

Screen Shot 2021-05-04 at 18 12 05

Unlocked:
Screen Shot 2021-05-04 at 18 12 13

Should the same method be used for any control that have a similar mechanism? Such as border control.

@cgaits
Copy link

cgaits commented May 4, 2021

The After is a better UI/UX as it better aligns with design software UI/UX.

@aaronrobertshaw
Copy link
Contributor

Raising some feedback on the existing border controls here in case it changes anything.

It could be confusing to have the width and color controls there when the border style is set to none (or default, depending on defaults), though.

@jameskoster
Copy link
Contributor Author

Should the same method be used for any control that have a similar mechanism? Such as border control.

If it is easy to re-purpose the existing padding control, that could serve as an interim. Ideally both the padding and border radii controls would be updated to use concepts outlined in #27331.

It could be confusing to have the width and color controls there when the border style is set to none (or default, depending on defaults), though.

I think the solution here is to not allow a "none" border style. That way the presence of the border is governed entirely by the width control and (hopefully) scope for confusion is reduced.

@cgaits
Copy link

cgaits commented May 5, 2021

Raising some feedback on the existing border controls here in case it changes anything.

It could be confusing to have the width and color controls there when the border style is set to none (or default, depending on defaults), though.

A check-mark and x would also help in choosing a border state, and it would visually guide the user.

@paaljoachim
Copy link
Contributor

paaljoachim commented May 6, 2021

Pasting in the gif seen in the Dimensions settings area here: #27331

100462262-e7c1ef00-30c1-11eb-8274-09eaa3073c3e

@cgaits
Copy link

cgaits commented May 6, 2021

Raising some feedback on the existing border controls here in case it changes anything.

It could be confusing to have the width and color controls there when the border style is set to none (or default, depending on defaults), though.

A check-mark and x would also help in choosing a border state, and it would visually guide the user.

I made an example of what would be in my opinion the best for the border state.
100461228-cc0e1700-30c8-11eb-8ac3-76d353dcc045

@jameskoster
Copy link
Contributor Author

@cgaits it's worth looking at the "Display options" menu in the typography panel designs shared in #27331:

It could be good to explore extending this heuristic up to the block level, making it possible to toggle panels (color, border, typography, layout) from a centralised interface.

@cgaits
Copy link

cgaits commented May 6, 2021

@cgaits it's worth looking at the "Display options" menu in the typography panel designs shared in #27331:

It could be good to explore extending this heuristic up to the block level, making it possible to toggle panels (color, border, typography, layout) from a centralised interface.

Yes, it is very intuitive and I like it; I was the publisher of a few magazines, including Trivia Times we used to make some heuristic puzzles. Is this a proposition for all WordPress menu items under the Gutenberg full editor?

@jasmussen
Copy link
Contributor

Yes, it is very intuitive and I like it; I was the publisher of a few magazines, including Trivia Times we used to make some heuristic puzzles. Is this a proposition for all WordPress menu items under the Gutenberg full editor?

Most of the details are best outlined on the ticket itself, but it boils down to this:

  • Global styles aims to provide themes a way to style most aspects of a page.
  • For every such style, a design tool is needed. A design tool can be "font size" or "letter-spacing".
  • Both because of the sheer amount of such design tools needed, and out of a need for block inspectors to be user friendly, we need a system that a) allows all blocks to have consistent interfaces that look and behave the same, b) have interfaces that can curate which controls are visible by default, and which aren't.

Ultimately, blocks, and block developers, should only need to declare support for a particular design tool, and not have to do any design work for it to appear in an intuitive and progressively unveiling way.

@aaronrobertshaw
Copy link
Contributor

Work toward refining the border block support UI is currently in progress in #31585.

The designs in this issue required some updates to the underlying block supports mechanism that are still pending review. Any help getting those reviewed will help move this forward.

@aaronrobertshaw
Copy link
Contributor

@jameskoster the border panel has been updated via #31585.

Other than the collapsed color control component I believe everything else is done regarding this issue. The new color control will be picked up by the panel when it is completed. In the meantime, are you happy to close this issue?

@paaljoachim
Copy link
Contributor

Hey @aaronrobertshaw
That sounds great!

I believe that Joen @jasmussen can comment on closing/not closing this issue when he gets back from his vacation, as @jameskoster is on a sabbatical until 8th of September,

@jasmussen
Copy link
Contributor

Let's close it! I'm quite sure Jay will reopen if things aren't up to snuff :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Design Feedback Needs general design feedback. [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
None yet
Development

No branches or pull requests

6 participants