-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine border control panel with design tools #31337
Comments
Goodness this is significantly better to interact with visually, great work. My initial thought after feeling it's just a lot easier to process is that perhaps the order is something to iterate on? I wonder for example if color would come as the last still in the list? Beyond that, I think it's a great iteration. |
The After is a better UI/UX as it better aligns with design software UI/UX. |
Raising some feedback on the existing border controls here in case it changes anything.
|
If it is easy to re-purpose the existing padding control, that could serve as an interim. Ideally both the padding and border radii controls would be updated to use concepts outlined in #27331.
I think the solution here is to not allow a "none" border style. That way the presence of the border is governed entirely by the width control and (hopefully) scope for confusion is reduced. |
A check-mark and x would also help in choosing a border state, and it would visually guide the user. |
Pasting in the gif seen in the Dimensions settings area here: #27331 |
I made an example of what would be in my opinion the best for the border state. |
Yes, it is very intuitive and I like it; I was the publisher of a few magazines, including Trivia Times we used to make some heuristic puzzles. Is this a proposition for all WordPress menu items under the Gutenberg full editor? |
Most of the details are best outlined on the ticket itself, but it boils down to this:
Ultimately, blocks, and block developers, should only need to declare support for a particular design tool, and not have to do any design work for it to appear in an intuitive and progressively unveiling way. |
Work toward refining the border block support UI is currently in progress in #31585. The designs in this issue required some updates to the underlying block supports mechanism that are still pending review. Any help getting those reviewed will help move this forward. |
@jameskoster the border panel has been updated via #31585. Other than the collapsed color control component I believe everything else is done regarding this issue. The new color control will be picked up by the panel when it is completed. In the meantime, are you happy to close this issue? |
Hey @aaronrobertshaw I believe that Joen @jasmussen can comment on closing/not closing this issue when he gets back from his vacation, as @jameskoster is on a sabbatical until 8th of September, |
Let's close it! I'm quite sure Jay will reopen if things aren't up to snuff :) |
Now that we have border controls (#30124 🎉) I took a little time to explore how we might apply some of the concepts outlined in #27331 to refine the UX here a bit.
Some of the suggestions can be implemented now, others will require underlying components that are yet to be built.
Here's a before / after, and a list of the changes:
select
, see Refine border style dropdown design #31333)theme.json
and block attributes #31641)The text was updated successfully, but these errors were encountered: