Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback: color settings for Post Title Block are confusing #31255

Closed
annezazu opened this issue Apr 27, 2021 · 4 comments
Closed

Feedback: color settings for Post Title Block are confusing #31255

annezazu opened this issue Apr 27, 2021 · 4 comments
Labels
[Block] Post Title Affects the Post Title Block [Type] Enhancement A suggestion for improvement. [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable

Comments

@annezazu
Copy link
Contributor

What problem does this address?

This feedback came up as part of the fifth call for testing for the FSE Outreach Program:

when adding a dark background color I tried to set the text color to a light color and was surprised when changing it had no effect. Only after thinking this through did I realise I needed to alter the Link Color in order to have the text color change. If the heading is a link then we should just have a single color control for Text color which changes both text and link colors. Users shouldn’t have to understand CSS inheritance – https://d.pr/v/kF8f75/jrq1PIYMYE

Speaking personally, I've also fallen prey to this as it's not quite intuitive that it's a link. This might be one of those things to adjust to in the query block context but feels worth passing along.

What is your proposed solution?

As suggested above, one possible solution is to have a single color control for Text color which changes both text and link colors.

This is semi related to #30719

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable [Block] Post Title Affects the Post Title Block labels Apr 27, 2021
@carolinan
Copy link
Contributor

carolinan commented Apr 28, 2021

I am not sure how this would work since some blocks will have both regular text and links.
Especially not if the link setting is expanded to include hover and focus colors and text decorations 🤔

@annezazu
Copy link
Contributor Author

Noting that this came up in the seventh call for testing and caused additional confusion as it seemed as though one should be able to change the color of the post title using the text color options.

@annezazu
Copy link
Contributor Author

This came up in the tenth call for testing as well:

when selecting the text color and link color, the color that would actually show would depend on the link settings if you were to ‘make title a link’ or not, which I found to be a bit confusing.

@annezazu
Copy link
Contributor Author

annezazu commented Feb 9, 2022

Closing this out in light of the more comprehensive issue here: #36972

@annezazu annezazu closed this as completed Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Title Affects the Post Title Block [Type] Enhancement A suggestion for improvement. [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable
Projects
None yet
Development

No branches or pull requests

2 participants