Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Template: Saving template and going back to the post content screen. #31096

Open
paaljoachim opened this issue Apr 22, 2021 · 3 comments
Open
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Apr 22, 2021

After saving a page template one is returned to the post content screen.
I have mixed in multiple adjustments in this issue. These really need to be made into separate issues.

It currently looks like this:
Page-template-screen-after-save-original

Here are some variants.
Version 1.
After-page-template-save-ver1

Version 2. This is a very crude mini modal/popup. Using a similar UI as clicking Public and Immediately.
After-page-template-save-ver2

Click-movie-template-sidebar-item-open-popup.mp4

Changes seen:
1- Add a template wrapper around the page template seen in the post content screen.
2- Make the Move template sidebar item clickable similar to Public and Immediately. With the following options:
Edit - New - Reset - Delete.
3- Selected page template is also selected in the Page Attributes Template drop down. #31101

Regarding deleting templates.
#31076

@jameskoster
Copy link
Contributor

1- Add a template wrapper around the page template seen in the post content screen.

This is an interesting idea, but without actually seeing the contents of the template I'm not sure what the value is? Unless you're editing the template, or have expressly requested to see the template in the context of post editing (something like #27847), then I worry this will only create unnecessary distractions in the post editing UX.

2- Make the Move template sidebar item clickable similar to Public and Immediately.

I think these are different interactions that should probably not be mixed. In the case of the visibility and publish dropdowns you are making a configuration. The template dropdown executes actions, so probably warrants a different UI.

Worth pointing out at this point that the template selector has been moved to it's own section in the Inspector:

Screenshot 2021-04-22 at 17 04 20

@paaljoachim
Copy link
Contributor Author

paaljoachim commented Apr 22, 2021

The reason for the Movie template is so visible in the post content screen, is that if the user decides on using a Page template it needs to be pretty obvious that it is there. Actually the content made in the Page template content area should be seen in the Post content screen as if it was a Reusable block. As it shows the content added in the Page template. The user might also add content in the post screen. So that post content made in the post screen would show up above or below the template post content.

@jameskoster
Copy link
Contributor

Actually the content made in the Page template content area should be seen in the Post content screen as if it was a Reusable block.

This sounds very similar to #27847. Worth reading Riad's latest reply there :)

@annezazu annezazu added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") and removed [Feature] Full Site Editing labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants