Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Template: Change button word "Apply" to "Save" #31091

Closed
paaljoachim opened this issue Apr 22, 2021 · 2 comments
Closed

Page Template: Change button word "Apply" to "Save" #31091

paaljoachim opened this issue Apr 22, 2021 · 2 comments
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@paaljoachim
Copy link
Contributor

In an issue @jameskoster suggested we make a change to a button that said "Design" (in FSE) to "Save".
I am suggesting we stick to the word "Save".

Current:
Page-template-apply

New:
Page-template-Save

Change-Apply-to-Save.mp4
@jameskoster
Copy link
Contributor

jameskoster commented Apr 22, 2021

Since #30793 the save flow between post and template editors has been unified, so we may be able to close this issue?

One thing we might explore is the label on the primary button in the post editor top bar now that these save flows have been connected. In the Site Editor we use a single "Save" button which works quite well. In the post/template editor(s) we have "Publish", "Update", and "Schedule" buttons, based on the status of the post.

Because it is now possible to edit all kinds of independent entities (reusable blocks, templates, template parts, site properties like title / tagline / logo, and so on) in the midst of editing a post, labels like "Schedule" lose some contextual value. In the worst case this particular label is confusing – "Can I schedule a change to my Site Title?".

Some ideas relating to this have already been discussed in #30800, so perhaps we should continue the conversation there?

@paaljoachim
Copy link
Contributor Author

paaljoachim commented Apr 23, 2021

I will go ahead and close this issue. Let's as you say continue the conversation in #30800 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants