Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page template: Adjust snackbar notification text. #31087

Closed
paaljoachim opened this issue Apr 22, 2021 · 5 comments
Closed

Page template: Adjust snackbar notification text. #31087

paaljoachim opened this issue Apr 22, 2021 · 5 comments
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Apr 22, 2021

After having created a template one is moved into the Template editing mode.

Page-Template-mode

A few things.
1- Top bar: Should have the template name title. New issue here: #31147
2- Adjust the snack bar text.

Adjustments:

3- Snack bar notification to go from "Custom template created. You're in template mode now." ->
"Template created. You are in template mode."

@jameskoster
Copy link
Contributor

1- Add Template name to the top bar.

We already have this in the Site Editor, it may be worth opening a dedicated issue to transplant it across to the template editor?

2- Adjust the sidebar movie template name.

I think when you switch to template editing, the document tab (Post or Page) should be replaced with the template details. This is how it works currently on trunk so I wonder if you're running the latest version? A snackbar already appears as you switch too:

snackbar.mp4

@paaljoachim
Copy link
Contributor Author

I should open an issue for adding the template name to the top bar as you mention. When entering the template mode the name is not seen in the top bar, but when saving the template name is suddenly seen there.

Thanks for sharing what is now in trunk! I am not running the RC version of Gutenberg, so it looks like I missed out on a few things.

@paaljoachim
Copy link
Contributor Author

paaljoachim commented Apr 23, 2021

I edited the original comment. I am focusing this issue only on the snackbar notification.

I have also added a new issue for Page template: Add template name to top bar
#31147

@paaljoachim paaljoachim changed the title Page template: Entering the page template mode Page template: Adjust snackbar notification text. Apr 23, 2021
@annezazu
Copy link
Contributor

@paaljoachim what are you suggesting here? I fear I'm misunderstanding! As Jay pointed out, this is already in place and I haven't seen any feedback from the outreach program that this is a confusing experience currently or that the language needs more clarity :D

@paaljoachim
Copy link
Contributor Author

Heya @annezazu

I am closing out this issue. No need to to anything here at the moment.
Thanks for noticing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants